QRCodeScanner unit tests #484
Conversation
Simplify code in order to understand all QRCodeScanner states; Remove unused QRButton component. The only place where QRCodeScanner is being used is in BottomNav component.
Rename files to .jsx in order to run successfully the component to test.
| let backCameraIndex = -1; | ||
| if (bestBackCamera) { | ||
| backCameraIndex = filteredDevices.findIndex(devices => | ||
| devices.device.deviceId === bestBackCamera.device.deviceId); | ||
| } | ||
|
|
||
| setCurrentDeviceIndex(backCameraIndex > -1 ? backCameraIndex : 0); |
There was a problem hiding this comment.
| let backCameraIndex = -1; | |
| if (bestBackCamera) { | |
| backCameraIndex = filteredDevices.findIndex(devices => | |
| devices.device.deviceId === bestBackCamera.device.deviceId); | |
| } | |
| setCurrentDeviceIndex(backCameraIndex > -1 ? backCameraIndex : 0); | |
| setCurrentDeviceIndex(Math.max(0, filteredDevices.findIndex(({ device: { deviceId } }) => deviceId === bestBackCamera?.device.deviceId))); |
|
|
||
| useEffect(() => { | ||
| navigator.mediaDevices.getUserMedia({ video: true }) | ||
| .then(stream => { |
There was a problem hiding this comment.
let's use async/await with try/catch everywhere instead of then/catch
| @@ -0,0 +1,270 @@ | |||
| import React, { useState, useEffect, useRef } from 'react'; | |||
There was a problem hiding this comment.
When refactoring or adding code, I think we should use always use typescript
There was a problem hiding this comment.
I agree with you. We usually refactor with TS. We'll definitely look into that. Do you think it is suitable to make that change in this PR?
There was a problem hiding this comment.
not necessarily in this PR
| setQrDetected(true); | ||
| // Redirect to the URL found in the QR code | ||
| const scannedUrl = result.data; | ||
| setTimeout(() => { |
There was a problem hiding this comment.
does this timeout have any effect, since there is a shorter timeout for switching the window.location.href defined right after?
| }; | ||
|
|
||
| const onUserMedia = () => { | ||
| if (webcamRef.current && webcamRef.current.video) { |
There was a problem hiding this comment.
The code is more readable if you return early on the opposite condition.
No description provided.